jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.07k stars 223 forks source link

Added PushUnchecked trait #1489

Closed ritchie46 closed 1 year ago

ritchie46 commented 1 year ago

This allows callers who build from trusted sources to elide the very expensive modulo check.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.02 :warning:

Comparison is base (6f8b5de) 83.72% compared to head (d703153) 83.70%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1489 +/- ## ========================================== - Coverage 83.72% 83.70% -0.02% ========================================== Files 389 389 Lines 41842 41853 +11 ========================================== + Hits 35031 35034 +3 - Misses 6811 6819 +8 ``` | [Impacted Files](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1489?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | | |---|---|---| | [src/array/fixed\_size\_list/mutable.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1489?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2FycmF5L2ZpeGVkX3NpemVfbGlzdC9tdXRhYmxlLnJz) | `65.78% <0.00%> (-5.14%)` | :arrow_down: | | [src/array/mod.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1489?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2FycmF5L21vZC5ycw==) | `77.65% <ø> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1489/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.