jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.07k stars 223 forks source link

feat: expose `non_null_sum` #1493

Closed ritchie46 closed 1 year ago

ritchie46 commented 1 year ago

This simd sum kernel is compiled for slices. If I want to make use of it, I currently need to allocate a primitive array, which is wasteful. This allows users to use that kernel on slices directly.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 :warning:

Comparison is base (f348fd6) 83.65% compared to head (9be41e0) 83.63%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1493 +/- ## ========================================== - Coverage 83.65% 83.63% -0.02% ========================================== Files 389 389 Lines 41892 41892 ========================================== - Hits 35043 35036 -7 - Misses 6849 6856 +7 ``` | [Impacted Files](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | | |---|---|---| | [src/compute/aggregate/sum.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1493?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2NvbXB1dGUvYWdncmVnYXRlL3N1bS5ycw==) | `77.08% <100.00%> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1493/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.