jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.07k stars 223 forks source link

Fix missing `UInt64` case for page filtering #1498

Closed poshcoe closed 1 year ago

poshcoe commented 1 year ago

Previously when attempting to deserialize UInt64 fields for page filtering, the read_filtered_pages function would incorrectly raise a NotYetImplemented error.

The cause was a missing match case for PrimitiveType:UInt64.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (320a90b) 83.63% compared to head (c7a2d1f) 83.63%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1498 +/- ## ======================================= Coverage 83.63% 83.63% ======================================= Files 389 389 Lines 41892 41892 ======================================= Hits 35036 35036 Misses 6856 6856 ``` | [Impacted Files](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | | |---|---|---| | [src/io/parquet/read/indexes/mod.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2lvL3BhcnF1ZXQvcmVhZC9pbmRleGVzL21vZC5ycw==) | `80.93% <ø> (ø)` | | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1498/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ritchie46 commented 1 year ago

Thanks!