Closed Qqwy closed 1 year ago
Patch coverage: 100.00
% and project coverage change: -0.02
:warning:
Comparison is base (
fb5e4d5
) 83.61% compared to head (e6f66d2
) 83.60%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@sundy-li The formatter CI pass should now also succeed. :blush:
Before, only Box was supported by ArrowArrayStreamReader.
This PR enables support for ArrowArrayStreams which are:
ArrowArrayStream
);&mut ArrowArrayStream
);Box<ArrowArrayStream, CustomAllocator>
;std::alloc::Box
;Arc<Mutex<>>
This is especially important when we receive a
*mut ArrowArrayStream
from C (or anywhere else outside of Rust) as it will need to be cleaned up in the correct way, so a normalBox
does not cut it.