jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.07k stars 220 forks source link

Adding new constructor for MutableListArray #1503

Closed cjermain closed 1 year ago

cjermain commented 1 year ago

This PR addresses #1502 by introducing a new constructor for MutableListArray that allows for building an object based on existing values from a MutableArray, Offsets, and MutableBitmap. I'm interested in feedback on this relative to the question posed in #1502, and happy to add tests if this seems like the right approach.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.15 :warning:

Comparison is base (99e30d3) 83.58% compared to head (3557894) 83.43%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1503 +/- ## ========================================== - Coverage 83.58% 83.43% -0.15% ========================================== Files 388 388 Lines 41912 42010 +98 ========================================== + Hits 35034 35053 +19 - Misses 6878 6957 +79 ``` | [Impacted Files](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1503?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | | |---|---|---| | [src/array/list/mutable.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1503?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2FycmF5L2xpc3QvbXV0YWJsZS5ycw==) | `74.24% <0.00%> (-5.65%)` | :arrow_down: | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1503/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.