jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.07k stars 220 forks source link

feat: add from_inner #1506

Closed ritchie46 closed 1 year ago

ritchie46 commented 1 year ago

This adds a complement of into_inner, from_inner. Allowing us to get data IN and OUT of arrow arrays without destructors being run, cached null counts being recomputed or checks being done in hot loops.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 34.34% and project coverage change: -0.12 :warning:

Comparison is base (0bfc3c0) 83.60% compared to head (0d3f947) 83.48%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1506 +/- ## ========================================== - Coverage 83.60% 83.48% -0.12% ========================================== Files 388 388 Lines 41912 41992 +80 ========================================== + Hits 35039 35056 +17 - Misses 6873 6936 +63 ``` | [Impacted Files](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1506?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | | |---|---|---| | [src/array/boolean/mod.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1506?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2FycmF5L2Jvb2xlYW4vbW9kLnJz) | `74.58% <0.00%> (-4.83%)` | :arrow_down: | | [src/array/primitive/mod.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1506?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2FycmF5L3ByaW1pdGl2ZS9tb2QucnM=) | `74.74% <0.00%> (-5.82%)` | :arrow_down: | | [src/buffer/immutable.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1506?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2J1ZmZlci9pbW11dGFibGUucnM=) | `75.75% <0.00%> (-9.72%)` | :arrow_down: | | [src/bitmap/immutable.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1506?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2JpdG1hcC9pbW11dGFibGUucnM=) | `79.62% <46.34%> (-8.98%)` | :arrow_down: | | [src/buffer/mod.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1506?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2J1ZmZlci9tb2QucnM=) | `92.30% <81.25%> (-7.70%)` | :arrow_down: | | [src/ffi/array.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1506?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2ZmaS9hcnJheS5ycw==) | `84.09% <100.00%> (+0.04%)` | :arrow_up: | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1506/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.