jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.06k stars 222 forks source link

defer null_count compute #1507

Closed ritchie46 closed 1 year ago

ritchie46 commented 1 year ago

fixes an edge case introduced in #1506. Only on arrays we know the null_count and don't have to recompute it.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 :warning:

Comparison is base (f46e26c) 83.47% compared to head (7653771) 83.47%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1507 +/- ## ========================================== - Coverage 83.47% 83.47% -0.01% ========================================== Files 388 388 Lines 41992 41996 +4 ========================================== + Hits 35053 35055 +2 - Misses 6939 6941 +2 ``` | [Impacted Files](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | | |---|---|---| | [src/ffi/array.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1507?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2ZmaS9hcnJheS5ycw==) | `84.29% <100.00%> (+0.19%)` | :arrow_up: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1507/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.