jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.06k stars 222 forks source link

Convert from_type to parent logical type before attempting a cast. #1508

Closed GPSnoopy closed 1 year ago

GPSnoopy commented 1 year ago

This is part of larger PR for polars https://github.com/pola-rs/polars/issues/9373.

Though it does seem to be the right thing when doing a cast and dealing with extension types.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2d2e705) 83.47% compared to head (2078857) 83.47%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1508 +/- ## ======================================= Coverage 83.47% 83.47% ======================================= Files 388 388 Lines 41996 41997 +1 ======================================= + Hits 35057 35058 +1 Misses 6939 6939 ``` | [Impacted Files](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | | |---|---|---| | [src/compute/cast/mod.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1508?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2NvbXB1dGUvY2FzdC9tb2QucnM=) | `90.67% <100.00%> (+0.01%)` | :arrow_up: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1508/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

GPSnoopy commented 1 year ago

Closing PR as per https://github.com/pola-rs/polars/issues/9373#issuecomment-1602265718