jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.07k stars 220 forks source link

Fixing dtype for MutableListArray #1509

Closed cjermain closed 1 year ago

cjermain commented 1 year ago

In #1503, the dtype was incorrectly taken for the inner array, instead of the dtype for the overall List. This PR fixes that line.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.03 :warning:

Comparison is base (0d568a3) 83.45% compared to head (67312c3) 83.43%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1509 +/- ## ========================================== - Coverage 83.45% 83.43% -0.03% ========================================== Files 388 388 Lines 42010 42010 ========================================== - Hits 35061 35051 -10 - Misses 6949 6959 +10 ``` | [Impacted Files](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1509?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | | |---|---|---| | [src/array/list/mutable.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1509?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2FycmF5L2xpc3QvbXV0YWJsZS5ycw==) | `74.24% <0.00%> (ø)` | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1509/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.