search

jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.07k stars 220 forks source link

feat: expose (utf8|binary)_substring #1539

Closed orlp closed 11 months ago

orlp commented 11 months ago

Closes https://github.com/jorgecarleitao/arrow2/issues/1538.

codecov[bot] commented 11 months ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (36e905d) 83.45% compared to head (d9c4b38) 83.45%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1539 +/- ## ======================================= Coverage 83.45% 83.45% ======================================= Files 388 388 Lines 42138 42142 +4 ======================================= + Hits 35165 35171 +6 + Misses 6973 6971 -2 ``` | [Files Changed](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | | |---|---|---| | [src/compute/substring.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2NvbXB1dGUvc3Vic3RyaW5nLnJz) | `100.00% <100.00%> (ø)` | | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ritchie46 commented 11 months ago

Can you run a cargo fmt?

orlp commented 11 months ago

Oops, sorry. Done.