jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.07k stars 220 forks source link

fix: slice values in list to fixed-size list cast #1544

Closed orlp closed 11 months ago

orlp commented 11 months ago

This issue was encountered in https://github.com/pola-rs/polars/issues/10533. In the ListArray to FixedSizeListArray cast the values slice is never actually sliced to the offset range.

codecov[bot] commented 11 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% :warning:

Comparison is base (c1446fb) 83.45% compared to head (fa624ed) 83.44%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1544 +/- ## ========================================== - Coverage 83.45% 83.44% -0.01% ========================================== Files 388 388 Lines 42142 42146 +4 ========================================== + Hits 35168 35170 +2 - Misses 6974 6976 +2 ``` | [Files Changed](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1544?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | | |---|---|---| | [src/compute/cast/mod.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1544?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2NvbXB1dGUvY2FzdC9tb2QucnM=) | `90.71% <100.00%> (+0.05%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1544/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

orlp commented 11 months ago

@ritchie46 Could you merge this?

ritchie46 commented 11 months ago

Yes!