jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.07k stars 220 forks source link

Update behavior of `any`/`all` for regular and Kleene logic #1545

Closed stinodego closed 11 months ago

stinodego commented 11 months ago

Changes

Both these changes are BREAKING!

codecov[bot] commented 11 months ago

Codecov Report

Patch coverage: 40.00% and project coverage change: +0.01% :tada:

Comparison is base (c1446fb) 83.45% compared to head (04e71f6) 83.46%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1545 +/- ## ========================================== + Coverage 83.45% 83.46% +0.01% ========================================== Files 388 388 Lines 42142 42146 +4 ========================================== + Hits 35168 35179 +11 + Misses 6974 6967 -7 ``` | [Files Changed](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1545?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | | |---|---|---| | [src/compute/boolean\_kleene.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1545?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2NvbXB1dGUvYm9vbGVhbl9rbGVlbmUucnM=) | `70.73% <30.76%> (-1.77%)` | :arrow_down: | | [src/compute/boolean.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1545?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2NvbXB1dGUvYm9vbGVhbi5ycw==) | `93.63% <100.00%> (+1.81%)` | :arrow_up: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1545/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.