jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.07k stars 220 forks source link

fix: LargeBinary to LargeList should be taken as a special #1550

Closed reswqa closed 11 months ago

reswqa commented 11 months ago

It seems that the order is important as LargeBinary => LargeList is a little special.

codecov[bot] commented 11 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03% :warning:

Comparison is base (3d7d9ac) 83.37% compared to head (594cd20) 83.34%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1550 +/- ## ========================================== - Coverage 83.37% 83.34% -0.03% ========================================== Files 388 388 Lines 42200 42212 +12 ========================================== Hits 35183 35183 - Misses 7017 7029 +12 ``` | [Files Changed](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1550?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | | |---|---|---| | [src/compute/cast/mod.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1550?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2NvbXB1dGUvY2FzdC9tb2QucnM=) | `90.83% <100.00%> (+0.39%)` | :arrow_up: | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1550/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

reswqa commented 11 months ago

I have tested this in https://github.com/pola-rs/polars/pull/10625 and that CI has passed.

reswqa commented 11 months ago

@ritchie46, would you mind taking a look at this, thanks!

ritchie46 commented 11 months ago

Looks good!