jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.06k stars 222 forks source link

Support nested decimal read write #1553

Closed ariesdevil closed 1 year ago

sundy-li commented 1 year ago

Any tests about this change?

ariesdevil commented 1 year ago

Any tests about this change?↳

Noop, there are no related tests for nested read/write :(

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 49.19% and project coverage change: -0.29% :warning:

Comparison is base (ba6a882) 83.34% compared to head (7cd89f3) 83.06%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1553 +/- ## ========================================== - Coverage 83.34% 83.06% -0.29% ========================================== Files 388 389 +1 Lines 42212 42581 +369 ========================================== + Hits 35183 35368 +185 - Misses 7029 7213 +184 ``` | [Files Changed](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | | |---|---|---| | [src/io/parquet/write/mod.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2lvL3BhcnF1ZXQvd3JpdGUvbW9kLnJz) | `77.06% <30.50%> (-11.26%)` | :arrow_down: | | [src/io/parquet/read/deserialize/nested.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2lvL3BhcnF1ZXQvcmVhZC9kZXNlcmlhbGl6ZS9uZXN0ZWQucnM=) | `67.00% <56.29%> (-4.10%)` | :arrow_down: | | [...rquet/read/deserialize/fixed\_size\_binary/nested.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2lvL3BhcnF1ZXQvcmVhZC9kZXNlcmlhbGl6ZS9maXhlZF9zaXplX2JpbmFyeS9uZXN0ZWQucnM=) | `57.75% <57.75%> (ø)` | | | [...arquet/read/deserialize/fixed\_size\_binary/basic.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1553?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2lvL3BhcnF1ZXQvcmVhZC9kZXNlcmlhbGl6ZS9maXhlZF9zaXplX2JpbmFyeS9iYXNpYy5ycw==) | `94.91% <100.00%> (ø)` | | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1553/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ariesdevil commented 1 year ago

@sundy-li add some tests, PTAL