search

jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.07k stars 221 forks source link

fix: More types supports cast to LargeList #1567

Closed reswqa closed 10 months ago

reswqa commented 10 months ago

More types(e.g. LargeUtf8) should also supports cast to LargeList. The only special branch is LargeBinary to LargeList.

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% :warning:

Comparison is base (fb7b5fe) 83.06% compared to head (eabcbf9) 83.06%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1567 +/- ## ========================================== - Coverage 83.06% 83.06% -0.01% ========================================== Files 391 391 Lines 42889 42890 +1 ========================================== Hits 35626 35626 - Misses 7263 7264 +1 ``` | [Files Changed](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1567?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | | |---|---|---| | [src/compute/cast/mod.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1567?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2NvbXB1dGUvY2FzdC9tb2QucnM=) | `90.84% <100.00%> (+0.01%)` | :arrow_up: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1567/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

reswqa commented 10 months ago

Seems that CI is unstable, but I assume it's not related to this change.

ritchie46 commented 10 months ago

Great!