search

jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.07k stars 221 forks source link

fix parquet datatype conversion from arrow #1570

Closed sundy-li closed 9 months ago

sundy-li commented 9 months ago

changes:

  1. fix parquet datatype conversion from arrow
  2. make clippy happy
codecov[bot] commented 9 months ago

Codecov Report

Patch coverage: 72.72% and no project coverage change.

Comparison is base (fb7b5fe) 83.06% compared to head (3645487) 83.06%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1570 +/- ## ======================================= Coverage 83.06% 83.06% ======================================= Files 391 391 Lines 42889 42898 +9 ======================================= + Hits 35626 35634 +8 - Misses 7263 7264 +1 ``` | [Files Changed](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1570?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | | |---|---|---| | [src/io/odbc/read/deserialize.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1570?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2lvL29kYmMvcmVhZC9kZXNlcmlhbGl6ZS5ycw==) | `0.00% <0.00%> (ø)` | | | [src/temporal\_conversions.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1570?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL3RlbXBvcmFsX2NvbnZlcnNpb25zLnJz) | `88.85% <33.33%> (ø)` | | | [src/io/parquet/read/schema/convert.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1570?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2lvL3BhcnF1ZXQvcmVhZC9zY2hlbWEvY29udmVydC5ycw==) | `94.73% <70.00%> (+0.04%)` | :arrow_up: | | [src/compute/cast/mod.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1570?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2NvbXB1dGUvY2FzdC9tb2QucnM=) | `90.84% <100.00%> (+0.01%)` | :arrow_up: | | [src/io/csv/read\_utils.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1570?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2lvL2Nzdi9yZWFkX3V0aWxzLnJz) | `91.39% <100.00%> (ø)` | | | [src/io/parquet/write/schema.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1570?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2lvL3BhcnF1ZXQvd3JpdGUvc2NoZW1hLnJz) | `77.20% <100.00%> (ø)` | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1570/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sundy-li commented 9 months ago

cc review @b41sh @TCeason

TCeason commented 9 months ago

LGTM.