jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.06k stars 221 forks source link

fix: fix nested decimal read and write #1573

Closed ariesdevil closed 1 year ago

ariesdevil commented 1 year ago

This PR fix the nested decimal read and write for all decimal precision, and all tests for all decimal precision and parquet versions.

codecov[bot] commented 1 year ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6271f48) 83.06% compared to head (5f20f78) 83.35%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1573 +/- ## ========================================== + Coverage 83.06% 83.35% +0.28% ========================================== Files 391 391 Lines 42898 42925 +27 ========================================== + Hits 35635 35780 +145 + Misses 7263 7145 -118 ``` | [Files](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1573?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | | |---|---|---| | [...arquet/read/deserialize/fixed\_size\_binary/basic.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1573?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2lvL3BhcnF1ZXQvcmVhZC9kZXNlcmlhbGl6ZS9maXhlZF9zaXplX2JpbmFyeS9iYXNpYy5ycw==) | `94.91% <100.00%> (ø)` | | | [src/io/parquet/write/fixed\_len\_bytes.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1573?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2lvL3BhcnF1ZXQvd3JpdGUvZml4ZWRfbGVuX2J5dGVzLnJz) | `100.00% <100.00%> (ø)` | | | [src/io/parquet/write/mod.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1573?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2lvL3BhcnF1ZXQvd3JpdGUvbW9kLnJz) | `90.09% <100.00%> (+13.03%)` | :arrow_up: | | [...rquet/read/deserialize/fixed\_size\_binary/nested.rs](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1573?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL2lvL3BhcnF1ZXQvcmVhZC9kZXNlcmlhbGl6ZS9maXhlZF9zaXplX2JpbmFyeS9uZXN0ZWQucnM=) | `57.75% <0.00%> (ø)` | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/jorgecarleitao/arrow2/pull/1573/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.