search

jorgecarleitao / arrow2

Transmute-free Rust library to work with the Arrow format
Apache License 2.0
1.06k stars 222 forks source link

[nightly] When compiling with `+nightly` one symbol is not found. #1599

Open keltia opened 9 months ago

keltia commented 9 months ago

When compiling arrow2 with the simd feature and under +nightly, one symbol is not found:

v1.77.0-nightly here.

error[E0432]: unresolved import `std::simd::SimdPartialEq`
 --> /Users/roberto/.cargo/registry/src/index.crates.io-6f17d22bba15001f/arrow2-0.17.4/src/types/simd/packed.rs:4:5
  |
4 |     SimdPartialEq,
  |     ^^^^^^^^^^^^^ no `SimdPartialEq` in `simd`
  |
  = help: consider importing one of these items instead:
          core::simd::prelude::SimdPartialEq
          std::simd::prelude::SimdPartialEq

So in src/types/simd/packed.rs, SimdPartialEq ought to be written as prelude::SimdPartialEq on line 4 (use).

keltia commented 9 months ago

I see this is a change that occurred in Rust after June, 2023 so your fixing nightly at this date works around this. So I guess it would be an incompatible change at this time. Still, while it makes sense for you, it will break for all other users so you might want to fix it. I wont submit a PR for this, change is trivial.