search

jorgecarleitao / parquet2

Fastest and safest Rust implementation of parquet. `unsafe` free. Integration-tested against pyarrow
Other
356 stars 59 forks source link

Replaced panics by errors on invalid pages #188

Closed evanrichter closed 2 years ago

evanrichter commented 2 years ago

fuzzing was turning up errors again, so I am making best-guess fixes (one per commit)

let me know if any of my fixes are the wrong idea and I can fix it up!

codecov-commenter commented 2 years ago

Codecov Report

Merging #188 (e91f2b4) into main (a0e66c2) will decrease coverage by 0.09%. The diff coverage is 42.85%.

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
- Coverage   85.71%   85.62%   -0.10%     
==========================================
  Files          84       84              
  Lines        8227     8243      +16     
==========================================
+ Hits         7052     7058       +6     
- Misses       1175     1185      +10
Impacted Files Coverage Δ
src/read/compression.rs 92.40% <27.27%> (-3.57%) :arrow_down:
src/read/page/reader.rs 86.31% <57.14%> (-1.26%) :arrow_down:
src/compression.rs 92.08% <66.66%> (-0.36%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

evanrichter commented 2 years ago

fuzzing seems pretty stable for now, but I will let it run overnight

edit: no further crashes found :)