Closed youngsofun closed 1 year ago
Base: 85.69% // Head: 85.69% // No change to project coverage :thumbsup:
Coverage data is based on head (
b1678c9
) compared to base (21a7f98
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This would add a significant dependency to this crate. Would it make sense to make this an optional feature under serde
. Something like this: https://github.com/jorgecarleitao/arrow2/blob/main/src/datatypes/field.rs#L3
@jorgecarleitao refactor done, it is a feature now.
@jorgecarleitao Is there anything else needs to improve?
Awesome, thanks a lot!
Is it ready to bump to 0.16.4? @jorgecarleitao
We need to bump to 0.17 - there are breaking changes in main. Released :)
use thrift for types in parquet_format_safe.
https://github.com/jorgecarleitao/parquet2/issues/200
it turns out that there are as many as 16 types that need to impl
De/Serialize
, so it is very troublesome to work it around outside.