Closed garrisonhess closed 1 year ago
Base: 85.05% // Head: 85.05% // No change to project coverage :thumbsup:
Coverage data is based on head (
f01654f
) compared to base (ac31d0e
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hey! Thanks a lot for this. I think that #211 fixed this by not pinning us into 0.3.2. Could you confirm?
Thanks for the quick reply!
Based on my reading of dependency version rules here, it seems to me that #211 would only reduce the minimum required version of async-stream to 0.3.0 from 0.3.2. Does that sound right? If that's correct, #211 wouldn't fix the issue because it wouldn't prevent parquet2 users from using 0.3.2.
Hi @jorgecarleitao! I noticed a compiler error while upgrading arrow2 in a separate project that uses async-stream version
0.3.2
. The other project's usage of version0.3.2
led to arrow2 and parquet2 both using it, which then led to a compiler error. I looked into it and found that async-stream's0.3.3
release contains a fix that parquet2 relies on. So this PR bumps parquet2's minimum async-stream version to0.3.3
to include the fix.Here is the code that fails to compile with async-stream
0.3.2
. https://github.com/jorgecarleitao/parquet2/blob/ac31d0e8140c518509091c1ad17b9d716a728a70/src/read/page/stream.rs#L120-L126Here is the resulting error:
This issue is fixed by https://github.com/tokio-rs/async-stream/pull/66, which is in the 0.3.3 release.