Closed ozgrakkurt closed 1 year ago
@jorgecarleitao I think it is all done except how to get the filters themselves. Can you give guidence on how can I construct the filter and pass it to write_column_chunk
?
Should be done now. Downstream code can optionally pass it in RowGroupIter along with the columns if the bloom_filter
feature is enabled.
This is a breaking change
One comment resolved but not sure about the other one
@jorgecarleitao how can I write tests for this?
@jorgecarleitao should be fixed
I think this just needs a test - would it be possible to perform a round-trip of a file with a written bloom filter to confirm that the filter we wrote is the filter we read?
Patch coverage: 93.52
% and project coverage change: +0.35
:tada:
Comparison is base (
ed0e1ff
) 85.05% compared to head (e75da23
) 85.40%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hey @jorgecarleitao, I wrote tests and also implemented async method to read bloom filters.
@jorgecarleitao can you check this when you have time?
nvm
closes https://github.com/jorgecarleitao/parquet2/issues/213