search

jorgecarleitao / parquet2

Fastest and safest Rust implementation of parquet. `unsafe` free. Integration-tested against pyarrow
Other
356 stars 59 forks source link

feat:add read_metadata_with_size to reduce seek when size is known. #225

Closed youngsofun closed 1 year ago

youngsofun commented 1 year ago

sometimes we collect infos of files before reading them, the info may already include the file size.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a0a2144) 85.10% compared to head (d683942) 85.11%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #225 +/- ## ======================================= Coverage 85.10% 85.11% ======================================= Files 86 86 Lines 8312 8315 +3 ======================================= + Hits 7074 7077 +3 Misses 1238 1238 ``` | [Impacted Files](https://codecov.io/gh/jorgecarleitao/parquet2/pull/225?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao) | Coverage Δ | | |---|---|---| | [src/read/mod.rs](https://codecov.io/gh/jorgecarleitao/parquet2/pull/225?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL3JlYWQvbW9kLnJz) | `90.96% <ø> (ø)` | | | [src/read/metadata.rs](https://codecov.io/gh/jorgecarleitao/parquet2/pull/225?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao#diff-c3JjL3JlYWQvbWV0YWRhdGEucnM=) | `77.96% <100.00%> (+1.18%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jorge+Leitao)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ritchie46 commented 1 year ago

Thanks! Make sense. :+1:

ritchie46 commented 1 year ago

Hmm.. I cannot merge this. I asked @jorgecarleitao for access, but we will have to wait until then.

sundy-li commented 1 year ago

Hmm.. I cannot merge this. I asked @jorgecarleitao for access, but we will have to wait until then.

Maybe you can email @jorgecarleitao asking for a member privilege if you want to maintain this repo, I just did that :)