search

jorgefsb / WTA

Frontend for the WTA project
0 stars 0 forks source link

CLICK ON EVERY ITEM AND MAKE SURE YOU CAN SEE THE ITEM. FIX IF YOU CAN'T #156

Closed timmcelwee closed 11 years ago

timmcelwee commented 11 years ago

TEST THIS. NOT OKAY AS IS. ITEMS NEED TO APPEAR CENTERED IN THE SPACE PROVIDED. AS IS, MOST ARE TO CLOSE TO THE LOWER GLOBAL LEVEL.

SOFIAPGM commented 11 years ago

Can you explain me better this please so this is clear! thanks @timmcelwee

timmcelwee commented 11 years ago

it means the item framing is off. Click on every item image. if the item is not centered perfectly in the space provided -- there is a problem. click on rams under t.cyia. R8 is the first image you will see. problem is you can't SEE all of it. you'll find this mistake throughout the site. it needs to be fixed.

On Wed, Dec 19, 2012 at 8:05 AM, SOFIA notifications@github.com wrote:

Can you explain me better this please so this is clear! thanks @timmcelweehttps://github.com/timmcelwee

— Reply to this email directly or view it on GitHubhttps://github.com/jorgefsb/WTA/issues/156#issuecomment-11535515.

chaconj commented 11 years ago

@timmcelwee

Is it ok if the items cut when the slider is there, the way it does in the Dior page?

We are going to make the image shrink depending on the size of the height of the browser as well so it never cuts when the product slider is down.

timmcelwee commented 11 years ago

yes, it's ok that the featured item gets cut when the slider appears. just like dior is perfect.

On Wed, Dec 19, 2012 at 12:00 PM, chaconj notifications@github.com wrote:

@timmcelwee https://github.com/timmcelwee

Is it ok if the items cut when the slider is there, the way it does in the Dior page?

We are going to make the image shrink depending on the size of the height of the browser as well so it never cuts when the product slider is down.

— Reply to this email directly or view it on GitHubhttps://github.com/jorgefsb/WTA/issues/156#issuecomment-11545717.

timmcelwee commented 11 years ago

K Sent via BlackBerry by AT&T

-----Original Message----- From: chaconj notifications@github.com Date: Wed, 19 Dec 2012 12:00:35 To: jorgefsb/WTAWTA@noreply.github.com Reply-To: jorgefsb/WTA reply@reply.github.com Cc: timmcelweetim@wetheadorned.com Subject: Re: [WTA] CLICK ON EVERY ITEM AND MAKE SURE YOU CAN SEE THE ITEM. FIX IF YOU CAN'T (#156)

@timmcelwee

Is it ok if the items cut when the slider is there, the way it does in the Dior page?

We are going to make the image shrink depending on the size of the height of the browser as well so it never cuts when the product slider is down.

Reply to this email directly or view it on GitHub: https://github.com/jorgefsb/WTA/issues/156#issuecomment-11545717