feat: fallback to pinentry-mac if no touchID

jorgelbg / pinentry-touchid

Custom GPG pinentry program for macOS that allows using Touch ID for fetching the password from the macOS keychain.

Apache License 2.0

521 stars 23 forks source link

feat: fallback to pinentry-mac if no touchID #21

Closed troyanov closed 2 years ago

troyanov commented 2 years ago

There might be a situation when device has TouchID, but once the lid is closed sensor.IsTouchIDAvailable() returns false. It happens when you connect and external display to your laptop and have the lid closed.

This PR adds a fallback scenario to call pinentry-mac when touchID is not available.

troyanov commented 2 years ago

Hi @jorgelbg can you please review this one?

lionello commented 2 years ago

Fixes #15

jorgelbg commented 2 years ago

@troyanov Nice finding! and thank you for the contribution! I never considered the chance where people used pinentry-touchid with the laptop closed 😅 (looking back is kind of obvious that a lot of people use their laptop in clamshell mode.