jorgelbg / pinentry-touchid

Custom GPG pinentry program for macOS that allows using Touch ID for fetching the password from the macOS keychain.
Apache License 2.0
559 stars 27 forks source link

Clarify why “Save in keychain” MUST be disabled #41

Open habibalamin opened 2 weeks ago

habibalamin commented 2 weeks ago

This fixes some language in the README.

With these three changes, I reckon most people will at least manually disable the checkbox every time they create a new entry for a new keypair, which may still result in some people forgetting when they renew their keypairs some years later, but it's better than the status quo.

Also, most people might still defaults write to make that the default, as even if they switch back to pinentry-mac, having to constantly enable that checkbox is better than causing a subtle breakage if they stick with pinentry-touchid that causes them to be unable to decrypt files and thinking their key is broken or something.


Honestly, this is just another reason to switch away from pinentry-mac at this point. It's a dead project, it creates work for the user — having to ensure the presence and right target of a symlink, having to remember this Save in keychain business, etc — and it kinda locks us in to its decisions.

At least a better fix for this particular issue might simply be to save the keypair without the comment, as the ID is still in the title, but that's a bit of a loss, so even better would be to search both with and without the comment before creating a new entry.