Closed cantino closed 10 years ago
@jorgemanrubia Also added a commit that fixes types in ActiveRecord getting prefixed with ::
, which was preventing correct id updates.
I see the specs failed, but the details link doesn't work.
He @cantino,
Tests look good: https://travis-ci.org/jorgemanrubia/forceps/pull_requests. It was using shippable (a CI service I tried and that considered it could replace Travis without asking me first). It will use Travis again from now on.
The PR looks great, thanks a lot. I will review it in detail tomorrow.
Thank you for the the great addition
Sure, we also hope you like the Audi references ;)
On Aug 13, 2014, at 4:56 PM, Jorge Manrubia notifications@github.com wrote:
He @cantino,
Tests look good: https://travis-ci.org/jorgemanrubia/forceps/pull_requests. It was using shippable (a CI service I tried and that considered it could replace Travis without asking me first). It will use Travis again from now on.
The PR looks great, thanks a lot. I will review it in detail tomorrow.
Thank you for the the great addition
— Reply to this email directly or view it on GitHub.
Merged. I will bump a new version. This was a much needed feature!
Sure, we also hope you like the Audi references ;)
Hehe indeed. If we are going to use a car, better pick a good one :)
@rogerneel and I have added support by splitting the full name on '::' and building the appropriate module paths. This should fix https://github.com/jorgemanrubia/forceps/issues/2.