search

jorgemanrubia / mailgun_rails

Rails Action Mailer adapter for Mailgun
MIT License
210 stars 70 forks source link

Upgraded to v3 api endpoint #42

Closed iainbeeston closed 9 years ago

iainbeeston commented 9 years ago

Right now the gem is hard-coded to use the v2 api, but v3 is out. According to mailgun, v3 is backwards compatible except for the bounces endpoint, which the gem does not use (details here - http://blog.mailgun.com/default-api-version-now-v3/).

This changes the (hard-coded) endpoint url from v2 to v3. Possibly solving #34.

jorgemanrubia commented 9 years ago

Thanks a lot @iainbeeston for the stream of contributions!

jorgemanrubia commented 9 years ago

hey @iainbeeston I was thinking in adding you as a repo collaborator? Are you interested?

iainbeeston commented 9 years ago

No thanks - I already contribute to many different gems, and I only use mailgun occasionally. However I think this gem is a great idea (thanks for making it available!) On Wed, 1 Apr 2015 at 10:19 am, Jorge Manrubia notifications@github.com wrote:

hey @iainbeeston https://github.com/iainbeeston I was thinking in adding you as a repo collaborator? Are you interested?

— Reply to this email directly or view it on GitHub https://github.com/jorgemanrubia/mailgun_rails/pull/42#issuecomment-88409682 .

iainbeeston commented 9 years ago

Could someone bump the version to 0.6.7 (or 0.7.0 considering the API endpoint has changed to v3) and publish a release to rubygems? On Wed, 1 Apr 2015 at 10:41 am, Iain Beeston iain.beeston@gmail.com wrote:

No thanks - I already contribute to many different gems, and I only use mailgun occasionally. However I think this gem is a great idea (thanks for making it available!) On Wed, 1 Apr 2015 at 10:19 am, Jorge Manrubia notifications@github.com wrote:

hey @iainbeeston https://github.com/iainbeeston I was thinking in adding you as a repo collaborator? Are you interested?

— Reply to this email directly or view it on GitHub https://github.com/jorgemanrubia/mailgun_rails/pull/42#issuecomment-88409682 .

jorgemanrubia commented 9 years ago

Done, version 0.7.0 released. Thanks!

iainbeeston commented 9 years ago

Great, thank you! On Fri, 3 Apr 2015 at 8:51 am, Jorge Manrubia notifications@github.com wrote:

Done, version 0.7.0 released. Thaks!

— Reply to this email directly or view it on GitHub https://github.com/jorgemanrubia/mailgun_rails/pull/42#issuecomment-89207574 .