Resolved warnings on MSVC

jorgen / json_struct

json_struct is a single header only C++ library for parsing JSON directly to C++ structs and vice versa

Other

422 stars 57 forks source link

Resolved warnings on MSVC #32

Closed noodlecollie closed 2 years ago

noodlecollie commented 2 years ago

This PR fixes a couple of warnings I came across:

There was an if statement missing a constexpr qualification on one of the conditions. Since the condition was compound, with one bit being constexpr and the other not, I separated it into two.
In certain cases, one of the template functions could trigger warnings about downcasting to integers of a different size, so I added an explicit cast to remove these warnings.

noodlecollie commented 2 years ago

Damn, it seems MSVC and GCC treat the if constexpr syntax differently, that's helpful 🙃 Will fix.

jorgen commented 2 years ago

Hi, slightly altered your pull request and pushed two commits: deb0e22617afdaba26e6105d1251f2b4aeb6d541 and 4f6d60c1c90aa55110c46342487d64615790ce8a. Thank you for the contribuition, I really apreciate it.