search

jorgenbuilder / ic-inspector

⭐⭐⭐⭐⭐ Chrome extension for decoding responses from the Internet Computer blockchain
https://chromewebstore.google.com/detail/ic-inspector/meaadkenfkhjakkkdapaallimhbdofck?hl=en&authuser=0
MIT License
52 stars 9 forks source link

Local development compatibility #41

Open Gekctek opened 8 months ago

Gekctek commented 8 months ago

Adding support for using local development canisters vs mainnet

Gekctek commented 8 months ago

Hey @jorgenbuilder I was just dabbling with making the your extension work with localhost I figured I would throw this up here to see if you have any interest in adding it, otherwise ill just keep it in my fork

jorgenbuilder commented 8 months ago

Hey Ethan, this has actually been on my radar for a long time. I'm excited to review and get this merged if it's ready to go.

Gekctek commented 8 months ago

It works, but im still testing it out for my canister development, so we can hold off from merging Be curious to your review insights, you know the code base best so not sure if some of my patterns fit what you are looking for

jorgenbuilder commented 8 months ago

How's this looking on your end? I'll wait until you give your stamp of approval before diving in, but very excited to make this happen :)

Gekctek commented 8 months ago

Everything is still working on my end, so you can go ahead and take a look

jorgenbuilder commented 8 months ago

Had a quick look today. Not a fan of the amount of reorganization, makes the diff harder for me to follow 😅. I might attempt to pick out the functional pieces this weekend.

Gekctek commented 8 months ago

That's fair. Wasn't sure how to tackle it because i had to detect the local vs not by the url (which has its own issues) and the current model initialized everything as globals no matter the context