search

jorgenschaefer / elpy

Emacs Python Development Environment
GNU General Public License v3.0
1.9k stars 262 forks source link

Remove explicit IPython support #1107

Open jorgenschaefer opened 7 years ago

jorgenschaefer commented 7 years ago

IPython 5 has changed a lot, and made integration with Emacs rather difficult. There have been a lot of error reports because of this. Elpy does not add much to basic Emacs support of IPython, and with the IPython 5 changes, using IPython in a comint buffer is getting a worse and worse idea.

Elpy should just do away with the explicit IPython support, and pass IPython error reports on to Emacs core.

ltsampros commented 7 years ago

Maybe open this issue in ipython's github issue tracker as well?

Their documentation states explicit support and offers advice as well.

rgemulla commented 6 years ago

What do you mean by dropping IPython support, i.e., what kind of support? I am using it with Emacs+elpy without any issues. (And to me, using it in a comint buffer with Emacs is a great idea ;))

jorgenschaefer commented 6 years ago

Elpy offers elpy-use-ipython which sets the environment to use ipython as the interactive shell. This has caused a lot of support requests, because ipython changed so much and seemed not designed to work in a comint buffer anymore (requires some semi-documented environment variable to work, for example). If those support requests are not an issue for you, I don't have any particular stakes in this. :-D

rgemulla commented 6 years ago

Hmm, most of the code can go now since we require Emacs 24.4 (at some point, we should probably start removing such dead code).

I am on windows, but I am not using ipython-script.py; not sure if this is still recent.

I am still in favor of keeping it, but simplifying to essentially setting the env variable, the interpreter and its argument. We can also have similar functionality for Jupyter console. If you agree to this, I can make a PR for this.

jorgenschaefer commented 6 years ago

I'm happy to keep the direct support if we have someone who can work on it. I don't use ipython at all :-D

galaunay commented 6 years ago

I don't use it either. I cannot be of any help here.

gopar commented 6 years ago

I don't use it as well

rgemulla commented 6 years ago

As there is not much to setup anymore, I suggest to drop the function (which I don't use myself as well) and write a "how to setup" entry in the "interactive python" section of documentation (where we should also recommend jupyter console, see #1152). I'll take a shot at this when I find some time.

rgemulla commented 6 years ago

See #1244. I also removed elpy-use-cpython because it doesn't do anything anymore (all code was for prior Emacs versions).