Exclude skipped tests from first report line

jorgenschaefer / emacs-buttercup

Behavior-Driven Emacs Lisp Testing

GNU General Public License v3.0

363 stars 44 forks source link

Exclude skipped tests from first report line #158

Closed snogge closed 4 years ago

snogge commented 4 years ago

The first line in a report:

Running 113 specs.

did take pending tests into account, but not tests that were skipped by the bin/buttercup -p option. Setting the spec status field to pending will exclude the skipped tests from the "Running" count.

snogge commented 4 years ago

Also see #30.

doublep commented 4 years ago

Please consider renaming buttercup--mark-skipped to buttercup-mark-skipped so that it becomes part of official API and can be used by other packages without fear of being removed in a next version.

I would also separate this into two functions: one that marks specs skipped according to some predicate and one that calls the first after building a predicate from a list of patterns. This way existing behavior of patterns would be preserved (the second function does it), while the first provides a very generic way to select using an arbitrary lambda.