search

jorgenschaefer / emacs-buttercup

Behavior-Driven Emacs Lisp Testing
GNU General Public License v3.0
360 stars 44 forks source link

Add API for better skip selection #177

Closed snogge closed 3 years ago

snogge commented 4 years ago

The new function buttercup-mark-skipped lets users mark specs as pending/skipped using either regular expressions or predicate functions.

@doublep , what do you think of this API? Maybe we should supply more data to the predicate function, like the full description string?

doublep commented 4 years ago

Should be fine.

Maybe we should supply more data to the predicate function, like the full description string?

As long as it receives the spec object and API to access it is public and stable, I don't see a need for that.

snogge commented 4 years ago

OK. I'll leave this PR open for a few more days in case anyone else wants to chime in. By the way, I have a working solution for the rest of #161, but it needs some more work and tests before its ready to put up. Frankly, the reporter is getting a bit too complicated by now. I really liked it when it was stateless....