Closed podiki closed 1 year ago
Ah, the usual trick of submitting a bug report reveals the answer, of course.
The problem is from 686b817 where the fix for #232 used the variable name for more recent Emacs than release versions. So the variable should be comp-enable-subr-trampolines
rather than native-comp-enable-subr-trampolines
. This was noted by @sergiodj in https://github.com/jorgenschaefer/emacs-buttercup/issues/230#issuecomment-1445538722.
Tested by making this change in the Guix package definition and the buttercup tests complete successfully with Emacs 28.2.
What is the proper fix then, track current release of Emacs for this variable? Or condition on the version to be usable for folks on git?
EDIT: Probably the proper fix to account for the variable name change is to check if either native-comp...
or comp-...
is t
and set to nil
. But I am not sure what version buttercup is meant to work with by default or how it handles bleeding edge changes in Emacs.
I believe this is #230 again. When building with Guix and using native compilation, the tests fail for
spy-on
. Here is the relevant part of the output:and backtrace of the guix build:
This is for v1.30, not sure what is wrong since this was supposed to be fixed. Note that the
homeless-shelter
is noting thatHOME
is not set during the build/test (though I did try setting it to/tmp
in the package build, perhaps a red herring here as it normally indicates something is relying onHOME
).Could be a Guix related issue with how the build is done, but I don't see what that is so far...