test: Change `pretty' test regexp to pass tests on emacs 30.

jorgenschaefer / emacs-buttercup

Behavior-Driven Emacs Lisp Testing

GNU General Public License v3.0

363 stars 44 forks source link

Closed nicolas-graves closed 1 year ago

nicolas-graves commented 1 year ago

This is a regexp change that should match test native compilation on both emacs 29 and emacs 30. Should fix https://github.com/jorgenschaefer/emacs-buttercup/issues/238.

mekeor commented 1 year ago

As discussed in Guix' bug tracker, this PR does not fix the problem: http://issues.guix.gnu.org/66298

mekeor commented 1 year ago

Looking at the code of this PR, and my previous comment in the buttercup-bug-report, it's obvious that the new regular expression

(seq
 "λ (bc-bt-foo \""

won't match

λ (bc-bt-foo

because of the trailing whitespace. Instead, it should begin like this, I guess:

(seq
 "λ (bc-bt-foo"

snogge commented 1 year ago

I did not notice this PR or #238 before fixing the issue in dfef8cf9c8404567c247b292a4c5752b47e2e4ec.