search

jorgenschaefer / emacs-buttercup

Behavior-Driven Emacs Lisp Testing
GNU General Public License v3.0
360 stars 44 forks source link

Use advice-add instead of obsolete defadvice #240

Closed tarsius closed 6 months ago

tarsius commented 7 months ago

... and other minor copy editing.

snogge commented 7 months ago

Maybe it's time to drop the 24.3 support...

tarsius commented 7 months ago

I didn't realize there still was/is support for a pre-nadvice Emacs release. Personally I would drop support for 24 at this point, but that is of course your call. I've actually dropped support for 25 for some packages recently and so far nobody complained (which wasn't the case when I last tried that two years ago, or so.)

snogge commented 6 months ago

I try to keep support for as long as possible as buttercup is the kind of tool that is used to verify that packages work on older Emacsen. But I've been looking for excuses to drop support for the older versions, so I'll drop Emacs 24.3 now.

snogge commented 6 months ago

Thank you for the contribution.

tarsius commented 6 months ago

But I've been looking for excuses to drop support for the older versions, so I'll drop Emacs 24.3 now.

Some maintainers of packages that use buttercup will feel the same way. :wink: