jorgensd / adios4dolfinx

Extending DOLFINx with checkpointing functionality
http://jsdokken.com/adios4dolfinx/
MIT License
19 stars 6 forks source link

Set default arguments for `engine` and `ghost_mode` in `read_mesh` #69

Closed finsberg closed 6 months ago

finsberg commented 6 months ago

Perhaps a controversial topic to ask for defaults, but in my opinion it would be good to set default values for engine and ghost_mode. For example engine="BP4" and ghost_mode=dolfinx.mesh.GhostMode.shared_facet.

jorgensd commented 6 months ago

I think it is fine, feel free to add a PR:)