search

jorgensd / dolfinx-tutorial

A reimplementation of the Springer book: https://github.com/hplgit/fenics-tutorial/, covering new topics as well as transitioning from dolfin to dolfinx
https://jorgensd.github.io/dolfinx-tutorial/
114 stars 64 forks source link

"buttons" for Github and binder(?) not appearing on tutorial pages #157

Closed mmoelter closed 11 months ago

mmoelter commented 1 year ago

On this page: https://jsdokken.com/dolfinx-tutorial/ the text indicates the reader can make comments or suggestions by clicking on the GitHub symbol to go to the issue tracker.

The next section indicates that, as an interactive notebook, the reader can run notebooks by using the Rocket (binder?) symbol.

As you can see in the screenshot, neither of those "buttons" are showing up. Screenshot 2023-11-14 at 4 26 39 PM

I have visited this tutorial in the past and those buttons were present.

jorgensd commented 1 year ago

I’ve seen this as well, and I have to figure out what has changed in jupyterbook

jorgensd commented 1 year ago

Could be that adding baseurl: https://jsdokken.com/ to the html config section works. Will test this once I've got extra time.

jorgensd commented 1 year ago

Related to: https://github.com/executablebooks/jupyter-book/issues/2076

jorgensd commented 11 months ago

Fixed on main branch

mmoelter commented 11 months ago

Thanks for the follow up and fix. I will have a few suggestions for wording/typos in the future.