jorgensd / dolfinx-tutorial

A reimplementation of the Springer book: https://github.com/hplgit/fenics-tutorial/, covering new topics as well as transitioning from dolfin to dolfinx
https://jorgensd.github.io/dolfinx-tutorial/
114 stars 64 forks source link

Issue on page /fem.html #167

Closed mmoelter closed 10 months ago

mmoelter commented 11 months ago

= 1st paragraph -- 1st sentence: ...for solving partial differential equations. should be ...for solving partial differential equations (PDEs).

-- 2nd sentence: The project was initiated in 2003, and is developed in collaboration between researchers from a number of universities and research institutes around the world. should be The project was initiated in 2003, and is developed in a collaboration among researchers from several universities and research institutes around the world.

-- 2nd paragraph, 1st sentence: The latest version of the FEniCS project, FEniCSx, consists of several building blocks, namely Basix, UFL, FFCx and DOLFINx.

should be (put Dolfinx first to match the order of the following text)

The latest version of the FEniCS project, FEniCSx, consists of several building blocks, DOLFINx, namely Basix, UFL, and FFCx.

= "What you will learn" -- 1st sentence: ...to solve PDEs in FEniCS. should be ...to solve PDEs using FEniCS.

-- sentence after bulleted list Important topics involve how... should be Important topics include: how...

= "How to use this tutorial" -- 2nd sentence: Therefore we will mostly... should be Therefore, we will mostly...

= "Obtaining the software" -- sentence after "Tutorial compatible docker images": ...is available in the Github Packages) should be (remove parentheses, add period) ...is available in the Github Packages.

-- sentence before heading "Official images": The tutorials can also be exported as a notebook or PDF by... should be The tutorials can also be exported as an IPython notebook or PDF by...

-- 2nd sentence after heading "Official images": ...one can directly access the image: should be ...one can directly access the image using:

-- sentence before heading "Installation from source": If all goes well, no error-messages should appear. should be If all goes well, no error messages should appear.

= Introduction to the finite element method -- 1st sentence: In the last decade, a wide range of lecture notes on finite elements methods has been made open access. should be In the last decade, several sets of lecture notes on finite element methods have been made open access.

-- sentence after bulleted list of materials: There has been written many good text-books on the finite element method, and we refer to the original FEniCS tutorial, for references to these,... should be Many good textbooks on the finite element method have been written, and we refer to the original FEniCS tutorial for references to these,...

jorgensd commented 11 months ago

@mmoelter Thanks for the suggestions. Your changes in a pull request would be welcomed, then your suggestions will get counted as your contributions.

mmoelter commented 11 months ago

Will make a pull request.

Matt

Matthew Moelter Professor Department of Physics California Polytechnic State University San Luis Obispo, CA 93407

Direct 805-756-2656 @.*** https://calpoly.zoom.us/j/8057562656

On Dec 19, 2023, at 11:24 AM, Jørgen Schartum Dokken @.***> wrote:

@mmoelterhttps://github.com/mmoelter Thanks for the suggestions. Your changes in a pull request would be welcomed, then your suggestions will get counted as your contributions.

— Reply to this email directly, view it on GitHubhttps://github.com/jorgensd/dolfinx-tutorial/issues/167#issuecomment-1863350321, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAMGLAPTYCZXPRKAR7562W3YKHSWFAVCNFSM6AAAAABA3U4KZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRTGM2TAMZSGE. You are receiving this because you were mentioned.Message ID: @.***>

jorgensd commented 10 months ago

@mmoelter Did you want to make this PR? I've seen the other PRs, but they don't seem to have these changes.

mmoelter commented 10 months ago

I did it shortly after your suggestion and then it was merged on Dec 20 (#168).