search

jorgensd / dolfinx-tutorial

A reimplementation of the Springer book: https://github.com/hplgit/fenics-tutorial/, covering new topics as well as transitioning from dolfin to dolfinx
https://jorgensd.github.io/dolfinx-tutorial/
110 stars 63 forks source link

Fixed some typos and wording. #171

Closed mmoelter closed 6 months ago

jorgensd commented 9 months ago

Hi Matt, Thanks for the suggestions. As you might have noticed there are both ipynb and py files in the git repo. These needs to be synced with jupytext, see: https://jupytext.readthedocs.io/en/latest/faq.html#can-i-use-jupytext-with-jupyterhub-binder-nteract-colab-saturn-or-azure

jorgensd commented 8 months ago

@mmoelter do you want me to make a branch out of this and fix the remaining changes to the Python files?

mmoelter commented 8 months ago

I apologize for the my lack of follow up. I’ll admit that I did not understand your earlier comment about making the .py files. As such it got put on a back burner, but I did not indicate that. It looks like “jupytext” is something I’ll have to learn about. I barely understand the issue/fork//pull/push/etc process as it is, so it might take a bit.

Anything you can do to help complete my suggested changes would be very welcome.

Thanks. Matt

On Mar 7, 2024, at 1:05 PM, Jørgen Schartum Dokken @.***> wrote:

@mmoelterhttps://github.com/mmoelter do you want me to make a branch out of this and fix the remaining changes to the Python files?

— Reply to this email directly, view it on GitHubhttps://github.com/jorgensd/dolfinx-tutorial/pull/171#issuecomment-1984469501, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAMGLAPLNZRNONJ7G6ZPCMDYXDJBRAVCNFSM6AAAAABB5CRUWKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBUGQ3DSNJQGE. You are receiving this because you were mentioned.Message ID: @.***>

jorgensd commented 6 months ago

Superseeded by #171 that has all your commits in it

mmoelter commented 6 months ago

I appreciate your following up and closing the ticket. Matt

Matthew Moelter Professor Department of Physics California Polytechnic State University San Luis Obispo, CA 93407

Direct 805-756-2656 @.*** https://calpoly.zoom.us/j/8057562656

On Apr 30, 2024, at 4:08 AM, Jørgen Schartum Dokken @.***> wrote:

Closed #171https://github.com/jorgensd/dolfinx-tutorial/pull/171.

— Reply to this email directly, view it on GitHubhttps://github.com/jorgensd/dolfinx-tutorial/pull/171#event-12656236901, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAMGLAIT2MPYDM3FDYQPXMLY753TTAVCNFSM6AAAAABB5CRUWKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGY2TMMRTGY4TAMI. You are receiving this because you were mentioned.Message ID: @.***>