search

jorgensd / dolfinx_mpc

Extension for dolfinx to handle multi-point constraints.
https://jorgensd.github.io/dolfinx_mpc/
MIT License
31 stars 12 forks source link

find ufcx via cmake before falling back on ffc-via-python #40

Closed minrk closed 1 year ago

minrk commented 1 year ago

avoids Python build dependency for cpp-only installs

minrk commented 1 year ago

alternative that might be preferable for maintainability would be to import the dolfinx logic for locating ufcx verbatim: https://github.com/FEniCS/dolfinx/blob/8177090c90594291722bd2e8621ea9b1b51988ff/cpp/CMakeLists.txt#L75-L85 https://github.com/FEniCS/dolfinx/blob/main/cpp/cmake/modules/FindUFCx.cmake

minrk commented 1 year ago

Actually, looking at dolfinx linkage to ufcx, I think this means that linking dolfinx will transitively include ufcx, so you don't need to detect it at all. Same might even go for basix? Do you want to build against different ufcx and basix than dolfinx, or is inheriting them okay?

jorgensd commented 1 year ago

Should be ok to inherit linking from DOLFINx I guess.