search

jorgepiloto / lamberthub

A set of Lambert's problem solvers
GNU General Public License v3.0
47 stars 5 forks source link

Fix gauss1809 #43

Closed jorgepiloto closed 3 years ago

jorgepiloto commented 3 years ago

This pull request improves the current implementation of gauss1809 solver by adding the first and second Gauss' equations in particular functions, fixing the way X is computed and following original Bate's formulation.

codecov-commenter commented 3 years ago

Codecov Report

Merging #43 (43c6728) into main (8cf3df5) will increase coverage by 0.05%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   90.02%   90.08%   +0.05%     
==========================================
  Files          19       19              
  Lines        1213     1220       +7     
  Branches      182      182              
==========================================
+ Hits         1092     1099       +7     
  Misses         70       70              
  Partials       51       51
Impacted Files Coverage Δ
src/lamberthub/p_solvers/gauss.py 91.83% <100.00%> (+1.36%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8cf3df5...43c6728. Read the comment docs.

jorgepiloto commented 3 years ago

All tests passed, merging this 🚀