search

jorgepiloto / lamberthub

A set of Lambert's problem solvers
GNU General Public License v3.0
47 stars 5 forks source link

Fix performance plotters #49

Closed jorgepiloto closed 3 years ago

jorgepiloto commented 3 years ago

This PR solves for #48 by ignoring points which did not converge.

jorgepiloto commented 3 years ago

Let us wait till the documentation is built. There, we could check the new performance comparison results. Gauss' solver should have more realistic values now 🤞🏽

codecov-commenter commented 3 years ago

Codecov Report

Merging #49 (be3a3a7) into main (ba8f3f9) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage   90.38%   90.38%           
=======================================
  Files          19       19           
  Lines        1259     1259           
  Branches      182      182           
=======================================
  Hits         1138     1138           
  Misses         70       70           
  Partials       51       51
Impacted Files Coverage Δ
src/lamberthub/plotting/iterations.py 100.00% <100.00%> (ø)
src/lamberthub/plotting/time.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ba8f3f9...be3a3a7. Read the comment docs.

jorgepiloto commented 3 years ago

The new values for both Gauss and Vallado are more realistic and according to the color scale! Merging this 🚀