search

jorgerojas26 / lazysql

A cross-platform TUI database management tool written in Go.
MIT License
590 stars 32 forks source link

Issues with Colorusage and Readability #1

Closed domsch1988 closed 14 hours ago

domsch1988 commented 6 months ago

So, i'm not sure on which end this issue is, but i'm not getting the same color output as your screenshots do grafik

Especially the unfocused treeview is using a Blue no matter which colorscheme i use. This is in Windows Terminal, tested with 3 colorschemes.

Additionally i feel like the contrast on the selected cell is pretty low. A darker foreground color for that would help readability.

jorgerojas26 commented 6 months ago

Hello, thanks for the issue.

I did not test in Windows, but definitely there is a problem with colors there. I will be investigating this issue, thanks for pointing out.

sabovyan commented 5 months ago

I am not sure but as far as I have noticed lazysql doesn't use the background color of the terminal, but instead uses default color which in my case was color1. and I had to tweak a little bit to have solid background color. colro1

andradei commented 1 week ago

Same kind of issue on linux when using a light theme in the terminal.

jorgerojas26 commented 1 week ago

Same kind of issue on linux when using a light theme in the terminal.

Yes, there are problems with the theme right now, colors are hardcoded. I can take a look at this, but feel free to open a PR if you know how to resolve this problem easily.

jorgerojas26 commented 1 week ago

@andradei @sabovyan @domsch1988 can you check if #70 fix the problem?

andradei commented 8 hours ago

@jorgerojas26 I'll check when the AUR updates the version. Thank you for working on this.