search

jorgicio / jorgicio-gentoo-overlay

Gentoo Overlay made by Jorgicio.
100 stars 50 forks source link

app-editors/visual-studio-code issue #176

Open PF4Public opened 5 years ago

PF4Public commented 5 years ago

Microsoft licensed Visual Studio Code - Open Source under MIT license. It is available in source code from GitHub. There is also Microsoft-branded Visual Studio Code, which is covered by Microsoft proprietary license and not MIT. This comment has more details for your reference.

Please, adapt the ebuild to use and build MIT-licensed source code instead of proprietary.

Unfortunately, MIT-licensed Visual Studio Code - Open Source lacks by default Visual Studio Extesions Marketplace, as seen here. This issue has been extensively discussed, but that discussion has no clear advice from Microsoft on the issue. There was only posted a link to this message, which probably arguably suggests, that it is possible to include Visual Studio Extesions Marketplace in a Visual Studio Code - Open Source built from source.

jorgicio commented 5 years ago

Do you mean: use this package to provide a source-based buildable one instead of the binary? I checked somewhere about that, and I noted this requires a recent version of Electron. I noted used a recent version of Electron (4.0 or recent). Sadly, in Gentoo Portage Tree, it only provides until the 2.x version, so by the moment, if you're asking so, I can't provide a source-based version yet. Also, the most recent version of Electron, as I found in the Gentoo Portage Overlays list, is the 3.1.0 by the Atom Overlay.

I'm think about renaming this package to add a -bin suffix to avoid confusions. I'll do the same with the vscodium package.

If I may be wrong, feel free to explain here.

I think I'll leave this issue open, this is an interesting thread.

PF4Public commented 5 years ago

Do you mean: use this package to provide a source-based buildable one instead of the binary?

That would have been ideal, but....

I checked somewhere about that, and I noted this requires a recent version of Electron. I noted used a recent version of Electron (4.0 or recent). Sadly, in Gentoo Portage Tree, it only provides until the 2.x version, so by the moment, if you're asking so, I can't provide a source-based version yet. Also, the most recent version of Electron, as I found in the Gentoo Portage Overlays list, is the 3.1.0 by the Atom Overlay.

Indeed that's all true. Just after writing this ticket I did some googling and found that it really needs a fairly recent electron (4.2.5 atm) and the most recent version that is available in overlays is indeed as you point out 3.1.8 and 4.0.7 in binary form. That's unfortunate :(

I'm think about renaming this package to add a -bin suffix to avoid confusions.

That's probably the only reasonable thing left to do. But you also need to mark it with the proper license (it is not MIT, unfortunately).

By the way, Arch managed to have vscode built from source, but they also have a far more recent version of electron.

jorgicio commented 5 years ago

I couldn't find the appropiate license (which is MS), so I had to create a file with that. Also, renamed the package from visual-studio-code-bin to vscode-bin.

I just searched and found that atom overlay has a source-based version of vscode (available as that name), you could try it first.

PF4Public commented 5 years ago

Thanks! I've also found atom overlay and currently trying to build vscode from there :) But anyway, thanks for mentioning, it might be usefull for a person from the future

atom actually does download the same MS-distributed binary archieve, but strips it off of binaries and builds the substitutes and it uses electron 3.1.8 for that. We'll see, how it goes.

jorgicio commented 5 years ago

Well, good luck with that. I'd build it, but it takes ages to do so. And yes, it uses the 3.1.8 version of Electron, as I noted here using vscodium.

As the source-based ebuild of vscode is available, it'd be a nice idea to do the same with vscodium.