Refactor code - Spacecrafts should hold a filter, not a filtered copy of the porkchop plot

jorialand / sonet_tfm_horia

Aerospace Engineering Final Master Thesis

2 stars 1 forks source link

Refactor code - Spacecrafts should hold a filter, not a filtered copy of the porkchop plot #13

Closed jorialand closed 4 years ago

jorialand commented 4 years ago

First, I should be able to start the program with a dummy spacecraft, just to test the code while I write it.
At start, all the porkchop plot (pcp) trajectories should be visible.
If I add a condition to the filter, only the filtered trajectories should be visible.
Once I know how to add a filter, refactor all the code according to this new paradigm.

jorialand commented 4 years ago

I think it's not clean to store a filtered pcp for every spacecraft. If my pcp has 10M rows, and I have 15 spacecrafts, I will store in ram operations with 150M rows? I think it'd be better to just store a filter in each spacecraft, and to filter the pcp only on demand.

jorialand commented 4 years ago

So, this issue is for developing the filter class, which will be a pandas dataframe, which stores the filter to be applied.

jorialand commented 4 years ago

As told by Miquel Sureda in yesterday's meeting. It's not correct to consider that a CREWED spacecraft will consist in a two way trip, as I was thinking.

A more correct approach would be to add a member variable, defining if that a concrete spacecraft will consist in a one or two way trip, the user should be able to access this member variable and modify it to control the number of trips to be considered for a spacecraft.

In this way, there could exist one way or two way CREWED spacecrafts, and one way or two way CARGO ones.

jorialand commented 4 years ago

Commit 70488c0cbc3affda917f40cd4aaff3211bb8dddd