joric / jorne

Jorne is an extended Corne keyboard with extra keys for brackets and international layouts
https://github.com/joric/jorne/wiki
487 stars 30 forks source link

Could you add to default keymap led_config_t for RGB Matrix Lighting? #16

Closed Veanvi closed 2 years ago

Veanvi commented 2 years ago

I created my LED_CONFIG_T, it works, but it seems with small bugs. Could you create a correct LED_CONFIG_T for Jorne and add it to QMK?

#ifdef RGB_MATRIX_ENABLE
led_config_t g_led_config = { {
    // Key Matrix to LED Index
    // Left Hand
    {  24,  23,  18,  17,  10,   9 },
    {  25,  22,  19,  16,  11,   8 },
    {  26,  21,  20,  15,  12,   7 },
    {  27, NO_LED, NO_LED,  14,  13,   6 },
    // Right hand
    {  52,  51,  46,  45,  38,  37 },
    {  53,  50,  47,  44,  39,  36 },
    {  54,  49,  48,  43,  40,  35 },
    {  55, NO_LED, NO_LED,  42,  41,  34 }
}, {
    // LED Index to Physical Position
    // Left hand
    { 102, 16 }, {  71, 13 }, {  39, 18 }, {  39,  32 }, { 72, 40 }, { 103, 43 },
    { 111, 50 }, { 103, 32 }, { 103, 19 }, { 103,   6 },
    {  86,  4 }, {  86, 18 }, {  86, 30 }, {  98,  46 },
    {  79, 44 }, {  71, 29 }, {  71, 16 }, {  71,   4 },
    {  55,  4 }, {  33, 18 }, {  33, 31 },
    {  39, 34 }, {  16, 21 }, {  16,  8 },
    {  22,  8 }, {   0, 21 }, {   0, 34 },
    {   7, 18 },
    // Right hand
    { 153, 16 }, { 184, 13 }, { 216, 18 }, { 216, 32 }, { 184, 40 }, { 153, 43 },
    { 144, 50 }, { 153, 32 }, { 153, 19 }, { 153,  6 },
    { 169,  4 }, { 169, 17 }, { 169, 31 }, { 157, 46 },
    { 176, 44 }, { 184, 29 }, { 184, 16 }, { 184,  3 },
    { 201,  4 }, { 201, 18 }, { 201, 31 },
    { 216, 35 }, { 216, 21 }, { 216,  8 },
    { 216,  8 }, { 216, 21 }, { 216, 35 },
    { 248, 19 }
}, {
    // LED Index to Flag
    // Left hand
    2, 2, 2, 2, 2, 2,
    1, 4, 4, 4,
    4, 4, 4, 1,
    1, 4, 4, 4,
    4, 4, 4,
    4, 4, 4,
    4, 4, 4,
    4,
    // Right hand
    2, 2, 2, 2, 2, 2,
    1, 4, 4, 4,
    4, 4, 4, 1,
    1, 4, 4, 4,
    4, 4, 4,
    4, 4, 4,
    4, 4, 4,
    4
} };
#endif
joric commented 2 years ago

Proper as in fix your config? I don't really have time. You can submit a pull request to QMK I'll co-author/approve. Have you seen https://github.com/joric/qmk/wiki/jorne#jorne-rgbm ?