search

jorijn / laravel-security-checker

Added Laravel functionality to Enlightn Security Checker. Adds a command to check for, and optionally emails you, vulnerabilities when they affect you.
https://jorijn.com
MIT License
198 stars 26 forks source link

Make Laravel 5.8 compatible #19

Closed DevDavido closed 5 years ago

DevDavido commented 5 years ago

This PR makes the package Laravel 5.8 compatible :)

DevDavido commented 5 years ago

Tests need fixes

jorijn commented 5 years ago

Thank you for your collaboration.

As looked at here: https://laravel-news.com/laravel-release-process

Laravel 5.5 LTS seems to have expired almost a year ago. However, Laravel 5.6 and 5.7 are still supported. Your PR removes support for those legacy versions and I would like to retain some backwards compatibility for people currently using this package and unable to upgrade to a newer (LTS) version of Laravel.

Did you remove these supported versions with anything other in mind? If so, please share. I'm always able to remove backwards compatibility by semver tagging the package with a v2.0.0 tag but I don't see any reason to do so right now.

DevDavido commented 5 years ago

Yes, my intention was to tag a new major version as I wrongly assumed that 5.8 would be an LTS release. Turns out it is not. In that case it's better to just modify this PR to make it 5.8 compatible without breaking 5.5 support as you suggested? :)

DevDavido commented 5 years ago

The current PR is backward compatible and supports the new Laravel version. Would you like to tag a new version @Jorijn?

jorijn commented 5 years ago

Thank you @DevDavido! I'll try and review your code this weekend. It it's all good, I'll push out v1.1.0.

matijakovacevic commented 5 years ago

Add (in a) commit message "resolves #18" to close the issue