search

jorio / Bugdom

🐛 Pangea Software's Bugdom for modern systems
https://pangeasoft.net/bug
Other
380 stars 23 forks source link

Update Windows Icon #26

Closed LordNyriox closed 2 years ago

LordNyriox commented 2 years ago

I converted the modern Mac/Linux icons to fit the Windows icon format, replacing the icon from the ancient "Ideas From the Deep" port. In compliance with Bugdom.exe.rc#L11, all embedded size layers are without PNG compression.

Icon layers scaled using @bricelam's ImageResizer 3.1.2, then combined into an ICO file using GIMP 2.10.32.

Size Layers: { 256x256 (32-bit color), 48x48 (32-bit color), 32x32 (original indexed icon) }

jorio commented 2 years ago

Thank you for your PR and for taking the time to research how to correctly generate the icon!

I'd like to keep the old 32x32 icon because I like the idea of preserving the OS 9 icon on at least one of the target platforms. However, adding a hi-res icon in addition to the old-school icon is a good idea.

To keep the file under 300 KB, I suggest keeping just 32x32 (indexed-color original), 48x48 (your rescaled version) and 256x256. Windows 10 will downscale the 256x256 icon as needed for sizes larger than 48.

LordNyriox commented 2 years ago

I suggest keeping just 32x32 (indexed-color original), 48x48 (your rescaled version) and 256x256.

Icon built and uploaded. Fair warning, I only use the browser interface of Github, so I cannot squash the commits in the PR branch.

jorio commented 2 years ago

Np, I'll squash it myself when I'm ready to merge. Thanks!

LordNyriox commented 2 years ago

@jorio: Off-topic, I am working on a "modernized" fork of Bugdom, and could use some technical advice on the code.

Would it be be alright for me to post Bugdom code questions in [https://github.com/jorio/Bugdom/issues/24], since implementing that issue is where I started my fork?

jorio commented 2 years ago

Sure! I'll be happy to help. You can also contact me directly if you wish (email address in my profile).

jorio commented 2 years ago

@LordNyriox, I think this PR got automatically closed when you recreated your repo before I got a chance to merge it. I can re-add the icon manually, or you can submit a new PR if you like.

LordNyriox commented 2 years ago

@jorio:

I can re-add the icon manually

I honestly forgot about this PR until after I had already reset my forked repository.

Feel free to manually rebase or merge the icon commit as you wish. 😄