📦 Enable support for git archive installs

jorisroovers / gitlint

Linting for your git commit messages

http://jorisroovers.github.io/gitlint

MIT License

791 stars 99 forks source link

📦 Enable support for git archive installs #470

Closed webknjaz closed 1 year ago

webknjaz commented 1 year ago

This patch enables the end-users to succeed installing from GitHub source Git archive URLs, letting setuptools-scm calculate the distribution version correctly, including the exports of non-tagged commits [1]. setuptools-scm is the underlying library that hatch-vcs wraps, which is why the configuration pre-requisites and runtime assumptions are inherited.

Resolves #464.

webknjaz commented 1 year ago

@jorisroovers coveralls upload failed. plz restart that one job.

coveralls commented 1 year ago

Coverage: 99.662%. Remained the same when pulling 4316b0d9c953441a5c7f249145b8eb52066fa2dc on webknjaz:maintenance/packaging-git-archives-support into a3ea8aeb6398befe8ed71f7458dd240e4da83e01 on jorisroovers:main.

webknjaz commented 1 year ago

@jorisroovers I've checked that putting a copy of .git_archival.txt into the second dist dir makes it work too: https://github.com/jorisroovers/gitlint/issues/464#issuecomment-1485095711. So now, it is possible to install both gitlint and gitlint-core by properly specifying where to get them from, in the pip install request.

Successfully installed arrow-1.2.3 click-8.1.3 gitlint-0.19.2.dev4+g4316b0d9 gitlint-core-0.19.2.dev4+g4316b0d9 python-dateutil-2.8.2 sh-1.14.3 six-1.16.0